Improve GetUserBans error handling & remove useless delcaration in PostSession

service/api/bans.go

@@ -42,7 +42,8 @@ func (rt *_router) GetUserBans(w http.ResponseWriter, r *http.Request, ps httpro
 	// Return ban list
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK) // is it needed?
-	json.NewEncoder(w).Encode(bans)
+
+	err = json.NewEncoder(w).Encode(bans) // write the response
 
 	if err != nil {
 		helpers.SendInternalError(err, "Error encoding json", w, rt.baseLogger)

service/api/post-session.go

@@ -30,7 +30,6 @@ func (rt *_router) PostSession(w http.ResponseWriter, r *http.Request, ps httpro
 		uid, err = rt.db.GetUserID(request.Name)
 	}
 	if db_errors.EmptySet(err) { // user does not exist
-		err = nil
 		uid, err = rt.db.CreateUser(request.Name)
 	}
 	if err != nil { // handle any other error